Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce new Output with OutputMeta #3466

Merged
merged 5 commits into from Mar 11, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

closes #3457

What's changed and what's your intention?

This pr refactors Output, turning the old one into OutputData and adding new OutputMeta. Since it's widely used across the project, we try to minimize the change by focusing on only changing the struct. Related feature addition will be made in a separate pr.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@shuiyisong shuiyisong requested a review from waynexia March 8, 2024 08:29
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 8, 2024
@waynexia waynexia requested a review from evenyag March 8, 2024 08:33
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 77.82258% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (3ee5336) to head (57602c9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3466      +/-   ##
==========================================
- Coverage   85.49%   85.01%   -0.49%     
==========================================
  Files         896      896              
  Lines      147518   147773     +255     
==========================================
- Hits       126127   125633     -494     
- Misses      21391    22140     +749     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed this patch and it looks good to me. Thanks for undertaking this overwhelming challenge 💯

src/common/query/src/lib.rs Show resolved Hide resolved
@waynexia waynexia enabled auto-merge March 8, 2024 08:48
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

src/common/query/src/lib.rs Outdated Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Mar 11, 2024
Merged via the queue into GreptimeTeam:main with commit 0bb9497 Mar 11, 2024
17 checks passed
@waynexia waynexia deleted the refactor/output branch March 11, 2024 02:36
@shuiyisong shuiyisong mentioned this pull request Mar 18, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Output for carrying output metadata
3 participants