New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce new Output
with OutputMeta
#3466
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3466 +/- ##
==========================================
- Coverage 85.49% 85.01% -0.49%
==========================================
Files 896 896
Lines 147518 147773 +255
==========================================
- Hits 126127 125633 -494
- Misses 21391 22140 +749 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've skimmed this patch and it looks good to me. Thanks for undertaking this overwhelming challenge 💯
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
closes #3457
What's changed and what's your intention?
This pr refactors
Output
, turning the old one intoOutputData
and adding newOutputMeta
. Since it's widely used across the project, we try to minimize the change by focusing on only changing the struct. Related feature addition will be made in a separate pr.Checklist