Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: more benchmarks for memtables #3491

Merged
merged 7 commits into from Mar 12, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Mar 12, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds two new benchmarks for memtables. It simulates data generated by TSBS: 4k hosts and 10s log interval.

  • full_scan benches speed to scan all rows and columns in a memtable
  • filter_1_host benches speed to scan and filter rows of 1 host
  • all benchmarks bench both time_series and the new memtable

It also removes a redundant file bench_merge_tree.rs in the benchmark

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 12, 2024
@evenyag evenyag marked this pull request as ready for review March 12, 2024 11:43
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge March 12, 2024 12:02
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Mar 12, 2024
Merged via the queue into GreptimeTeam:main with commit 7c895e2 Mar 12, 2024
42 of 48 checks passed
@v0y4g3r v0y4g3r deleted the bench/merge-tree branch March 12, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants