Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common-time): allow building nanos timestamp from parts split from i64::MIN #3493

Merged
merged 1 commit into from Mar 13, 2024

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Mar 12, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Similar situation to chronotope/chrono#1289

Fix the underflow and add some helper constant variables about min/max timestamp.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

…m i64::MIN

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (7c895e2) to head (007bc6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3493      +/-   ##
==========================================
- Coverage   85.31%   85.30%   -0.01%     
==========================================
  Files         903      903              
  Lines      149659   149704      +45     
==========================================
+ Hits       127683   127707      +24     
- Misses      21976    21997      +21     

@zhongzc zhongzc requested a review from QuenKar March 12, 2024 15:57
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 904484b Mar 13, 2024
18 checks passed
@fengjiachun fengjiachun deleted the zhongzc/fix-timestamp-nanos-underflow branch March 13, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants