Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redudant PromStoreProtocolHandler::write #3553

Merged
merged 1 commit into from Mar 22, 2024
Merged

refactor: remove redudant PromStoreProtocolHandler::write #3553

merged 1 commit into from Mar 22, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Mar 20, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Remove PromStoreProtocolHandler::write and rename PromStoreProtocolHandler::write_fast to write to avoid confusion.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 20, 2024
@v0y4g3r
refactor: remove redudant PromStoreProtocolHandler::write API and ren…
f354e00 
…ame PromStoreProtocolHandler::write_fast to write
@v0y4g3r v0y4g3r force-pushed the feat/remove-redundant-prom-write branch from b08d6fa to f354e00 Compare March 20, 2024 14:40
@v0y4g3r v0y4g3r marked this pull request as ready for review March 20, 2024 15:41
waynexia
waynexia approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong added this pull request to the merge queue Mar 22, 2024
@waynexia

This comment was marked as outdated.

Sign in to view
Merged via the queue into GreptimeTeam:main with commit 86fb9d8 Mar 22, 2024
32 checks passed
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@shuiyisong shuiyisong shuiyisong approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

@evenyag evenyag Awaiting requested review from evenyag

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@v0y4g3r @waynexia @shuiyisong