feat: Support printing postgresql's `bytea` data type in its "hex" and "escape" format #3567

J0HN50N133 · 2024-03-22T15:25:11Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3438

What's changed and what's your intention?

Support printing postgresql's bytea data type in its "hex" and "escape" format.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change
Support printing postgresql's bytea data type in its "hex" and "escape" format. And add a general way to set session config value, which make it easier to support Support outputting various date styles for postgresql #3442 .
How does this PR work? Need a brief introduction for the changed logic
Add a new field configuration_variables in Session and QueryContext. The values in QueryContext may be changed by set statement and will be finally pass to Session. And the config value will affect the output.
Different output of bytea is implemented by wrapper: HexOutputBytea and EscapeOutputBytea which reimplement ToSqlText and delegate ToSql to inner data.
Describe any limitations of the current code
SessionConfigValue is coupled with sql::ast::Value. And configuration parameters is not well-organized.

Checklist

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR does not require documentation updates.

…"escape" format in ugly way

J0HN50N133 · 2024-03-22T15:26:57Z

@MichaelScofield I would like to add some related integration test, but didn't find a way. Would you please tell me how to do this?

codecov · 2024-03-22T15:42:54Z

Codecov Report

Attention: Patch coverage is 76.68161% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 84.79%. Comparing base (58c7858) to head (6ae783f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
- Coverage   85.20%   84.79%   -0.42%     
==========================================
  Files         926      928       +2     
  Lines      153645   153851     +206     
==========================================
- Hits       130919   130461     -458     
- Misses      22726    23390     +664

rename 'set_configuration_parameter' in statement_.rs to 'set_session_config'

src/session/src/context.rs

src/servers/src/postgres/handler.rs

src/servers/src/postgres/types/bytea.rs

src/session/src/lib.rs

tests-integration/tests/sql.rs

MichaelScofield · 2024-03-25T02:30:30Z

@MichaelScofield I would like to add some related integration test, but didn't find a way. Would you please tell me how to do this?

I'd suggest putting the tests in file "/tests-integration/tests/sql.rs". But I see you've already done this.

src/operator/src/statement.rs

src/operator/src/error.rs

src/session/src/context.rs

src/session/src/session_config.rs

src/session/src/context.rs

refactor: use Arc<DashMap> instead of DashMap in QueryContext refactor: use Arc<DashMap> instead of DashMap in QueryContext Avoid expensive clone refactor: use unreachable!() instead of unimplemented!() refactor: move the encode bytea by format type logic into encoder test: add binary format integration test case

…omplex typing

J0HN50N133 · 2024-03-26T14:56:33Z

@sunng87 Thanks for your advice, helps simplifying the implementation a lot.

Signed-off-by: tison <wander4096@gmail.com>

sunng87

LGTM. Thank you @J0HN50N133 for your patient and fast response!

J0HN50N133 and others added 4 commits March 21, 2024 17:51

feat: support set variable statement of session

c7c29ea

feat: support printing postgresql's bytea data type in its "hex" and …

be1e49e

…"escape" format in ugly way

refactor: add 'SessionConfigValue' type and unify the name

e3bcb44

Merge branch 'main' into feature_bytea

3077937

github-actions bot added Invalid PR Title docs-not-required This change does not impact docs. labels Mar 22, 2024

J0HN50N133 changed the title ~~Support printing postgresql's bytea data type in its "hex" and "escape" format~~ feat: Support printing postgresql's bytea data type in its "hex" and "escape" format Mar 22, 2024

github-actions bot removed the Invalid PR Title label Mar 22, 2024

doc: add license header

cae1430

J0HN50N133 added 5 commits March 22, 2024 23:46

refactor: confine coupling with 'sql::ast::Value' in SessionConfigValue

d9f0260

refactor: move all bytea wrapper into bytea.rs

5a31138

fix: remove unused import in context.rs and postgres.rs

03e8bd0

refactor: rename 'set_configuration_parameter' to 'set_session_config'

0f3ab19

rename 'set_configuration_parameter' in statement_.rs to 'set_session_config'

refactor: use mod to organize options via macro

3a5fbfc

sunng87 reviewed Mar 22, 2024

View reviewed changes

src/session/src/context.rs Outdated Show resolved Hide resolved

refactor: re-model the session config value with static type

5d1880e

J0HN50N133 force-pushed the feature_bytea branch from 49e5acc to 5d1880e Compare March 22, 2024 21:50

test: add integration test

170a378

sunng87 reviewed Mar 24, 2024

View reviewed changes

src/servers/src/postgres/handler.rs Outdated Show resolved Hide resolved

sunng87 reviewed Mar 24, 2024

View reviewed changes

src/servers/src/postgres/handler.rs Outdated Show resolved Hide resolved

src/servers/src/postgres/types/bytea.rs Show resolved Hide resolved

src/session/src/lib.rs Outdated Show resolved Hide resolved

tests-integration/tests/sql.rs Outdated Show resolved Hide resolved

MichaelScofield reviewed Mar 25, 2024

View reviewed changes

J0HN50N133 added 3 commits March 25, 2024 14:28

test: add ut for byte related type

12b972f

doc: remove TODO of bytea_output

61cb858

J0HN50N133 requested a review from MichaelScofield March 25, 2024 07:00

killme2008 requested a review from sunng87 March 25, 2024 17:30

refactor: simplify the implementation with simple struct instead of c…

817149a

…omplex typing

fix: typo of 'Available'

f1defe9

J0HN50N133 force-pushed the feature_bytea branch from b009cff to f1defe9 Compare March 26, 2024 08:22

tisonkun added 2 commits March 27, 2024 00:34

Merge branch 'main' into feature_bytea

f6f0a9d

fix compile

6ae783f

Signed-off-by: tison <wander4096@gmail.com>

sunng87 approved these changes Mar 26, 2024

View reviewed changes

MichaelScofield approved these changes Mar 27, 2024

View reviewed changes

MichaelScofield added this pull request to the merge queue Mar 27, 2024

Merged via the queue into GreptimeTeam:main with commit 83643eb Mar 27, 2024
18 checks passed

J0HN50N133 deleted the feature_bytea branch March 27, 2024 04:02

tisonkun mentioned this pull request Apr 9, 2024

feat: support count_tags option orhun/git-cliff#599

Open

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support printing postgresql's `bytea` data type in its "hex" and "escape" format #3567

feat: Support printing postgresql's `bytea` data type in its "hex" and "escape" format #3567

J0HN50N133 commented Mar 22, 2024 •

edited by MichaelScofield

J0HN50N133 commented Mar 22, 2024

codecov bot commented Mar 22, 2024 •

edited

MichaelScofield commented Mar 25, 2024

J0HN50N133 commented Mar 26, 2024

sunng87 left a comment

feat: Support printing postgresql's bytea data type in its "hex" and "escape" format #3567

feat: Support printing postgresql's bytea data type in its "hex" and "escape" format #3567

Conversation

J0HN50N133 commented Mar 22, 2024 • edited by MichaelScofield

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Checklist

J0HN50N133 commented Mar 22, 2024

codecov bot commented Mar 22, 2024 • edited

Codecov Report

MichaelScofield commented Mar 25, 2024

J0HN50N133 commented Mar 26, 2024

sunng87 left a comment

Choose a reason for hiding this comment

feat: Support printing postgresql's `bytea` data type in its "hex" and "escape" format #3567

feat: Support printing postgresql's `bytea` data type in its "hex" and "escape" format #3567

J0HN50N133 commented Mar 22, 2024 •

edited by MichaelScofield

codecov bot commented Mar 22, 2024 •

edited