Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set http response chartset to utf-8 when using table format #3571

Merged
merged 1 commit into from Mar 25, 2024

Conversation

xxxuuu
Copy link
Contributor

@xxxuuu xxxuuu commented Mar 23, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

fixed the problem mentioned in this PR: #3539

What's changed and what's your intention?

The table format contains non-ASCII characters, and the content-type does not specify a character set. Although most clients will try to using UTF-8, but we cannot make this assumption and need to explicitly set it.

before:
before

after:
after

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the Doc not needed This PR do not impact docs label Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (1f0fc40) to head (5f92712).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3571      +/-   ##
==========================================
- Coverage   85.36%   85.06%   -0.31%     
==========================================
  Files         910      911       +1     
  Lines      152033   152425     +392     
==========================================
- Hits       129784   129661     -123     
- Misses      22249    22764     +515     

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

Merging ..

@tisonkun tisonkun added this pull request to the merge queue Mar 25, 2024
Merged via the queue into GreptimeTeam:main with commit 2ad0b24 Mar 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc not needed This PR do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants