Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retain original headers #3572

Merged
merged 2 commits into from Mar 25, 2024
Merged

chore: retain original headers #3572

merged 2 commits into from Mar 25, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Copied files need not to contain our own headers, but retain the owner's.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (2ad0b24) to head (8d87de3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
- Coverage   85.43%   85.05%   -0.38%     
==========================================
  Files         911      911              
  Lines      152425   152425              
==========================================
- Hits       130220   129645     -575     
- Misses      22205    22780     +575     

@evenyag evenyag enabled auto-merge March 25, 2024 03:35
@tisonkun
Copy link
Contributor Author

@evenyag Thanks for your review. The merge queue will rebase on main and test by default so we don't need to update to main manually which run once more CI.

The intention to "Always suggest update branch" is for a fast path merge main to catch up some fixes in other PRs.

@evenyag evenyag added this pull request to the merge queue Mar 25, 2024
Merged via the queue into GreptimeTeam:main with commit 0f1747b Mar 25, 2024
19 checks passed
@tisonkun tisonkun deleted the licenses branch May 3, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants