Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pk_cache in compat reader #3576

Merged
merged 5 commits into from Mar 26, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

SELECT with a filter will decode the primary key in advance, before compat reader. And compat reader doesn't handle the cache which leads to this error.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 25, 2024
@waynexia waynexia enabled auto-merge March 25, 2024 12:02
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Mar 25, 2024
@waynexia waynexia removed this pull request from the merge queue due to a manual request Mar 25, 2024
@waynexia waynexia enabled auto-merge March 25, 2024 12:24
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (992c7ec) to head (f497f29).
Report is 6 commits behind head on main.

❗ Current head f497f29 differs from pull request most recent head 8d48088. Consider uploading reports for the commit 8d48088 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3576      +/-   ##
==========================================
- Coverage   85.46%   84.89%   -0.58%     
==========================================
  Files         911      917       +6     
  Lines      152506   152874     +368     
==========================================
- Hits       130346   129785     -561     
- Misses      22160    23089     +929     

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia added this pull request to the merge queue Mar 26, 2024
Merged via the queue into GreptimeTeam:main with commit 7456515 Mar 26, 2024
17 checks passed
@waynexia waynexia deleted the fix-pk-cache branch March 26, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants