Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support time range in copy table #3583

Merged

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Mar 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds support for specifying time range to export when executing COPY <TABLE> TO statement.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-required This change requires docs update. label Mar 26, 2024
@v0y4g3r v0y4g3r marked this pull request as ready for review March 26, 2024 07:25
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 77.57353% with 183 lines in your changes are missing coverage. Please review.

Project coverage is 84.87%. Comparing base (bf14d33) to head (45646b6).
Report is 6 commits behind head on main.

❗ Current head 45646b6 differs from pull request most recent head d1dbeb1. Consider uploading reports for the commit d1dbeb1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3583      +/-   ##
==========================================
- Coverage   85.25%   84.87%   -0.38%     
==========================================
  Files         917      924       +7     
  Lines      152869   153519     +650     
==========================================
- Hits       130324   130299      -25     
- Misses      22545    23220     +675     

@evenyag
Copy link
Contributor

evenyag commented Mar 26, 2024

Sqlness test is failed

@v0y4g3r
Copy link
Contributor Author

v0y4g3r commented Mar 26, 2024

Sqlness test is failed

@WenyXu is fixing sqlness suites.

@evenyag
Copy link
Contributor

evenyag commented Mar 26, 2024

Sqlness test is failed

@WenyXu is fixing sqlness suites.

The failure is time-zone related. I'm unsure why it occurs in this PR. @WenyXu @v0y4g3r

Result unexpected, path:"./tests/cases/distributed/common/function/date.sql"
[
    ... skip(72) ...,
~   | 2023-12-06 07:39:46:222                                                    | -> | 2023-12-06 15:39:46:222                                                    |,
    ... skip(7) ...,
~   | 2023-12-06 07:39:46:000                                                    | -> | 2023-12-06 15:39:46:000                                                    |,
    ... skip(120) ...,
~   | 1992-01-01 00:00:00:000                            | -> | 1992-01-01 08:00:00:000                            |,
~   | 1993-12-30 00:00:00:000                            | -> | 1993-12-30 08:00:00:000                            |,
~   | 2023-12-06 00:00:00:000                            | -> | 2023-12-06 08:00:00:000                            |,
    ... skip(7) ...,
~   | 1970-01-01 00:00:00:001                             | -> | 1970-01-01 08:00:00:001                             |,
~   | 1970-01-01 00:00:00:002                             | -> | 1970-01-01 08:00:00:002                             |,
~   | 1970-01-01 00:00:00:003                             | -> | 1970-01-01 08:00:00:003                             |,
    ... skip(6) ...
]

@v0y4g3r v0y4g3r force-pushed the feat/specify-time-range-in-copy-table branch from 45646b6 to d1dbeb1 Compare March 26, 2024 10:08
Copy link
Collaborator

@MichaelScofield MichaelScofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this asap

@v0y4g3r v0y4g3r enabled auto-merge March 26, 2024 11:20
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Mar 26, 2024
Merged via the queue into GreptimeTeam:main with commit 1759294 Mar 26, 2024
18 checks passed
@v0y4g3r v0y4g3r deleted the feat/specify-time-range-in-copy-table branch March 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants