Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor drop table executor #3589

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3516

What's changed and what's your intention?

  1. Refactor drop table executor
  2. Support to drop metric table (Drop Database statement)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 37.73585% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 84.79%. Comparing base (d832795) to head (7fc40b7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
- Coverage   85.16%   84.79%   -0.37%     
==========================================
  Files         927      930       +3     
  Lines      153797   154237     +440     
==========================================
- Hits       130987   130792     -195     
- Misses      22810    23445     +635     

@shuiyisong shuiyisong added this pull request to the merge queue Mar 27, 2024
Merged via the queue into GreptimeTeam:main with commit 623c930 Mar 27, 2024
18 checks passed
@WenyXu WenyXu mentioned this pull request Mar 27, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants