Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create regions persist true #3590

Merged

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

When creating table, the step of create region should persist its's status.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested a review from WenyXu March 27, 2024 05:05
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (922b1a9) to head (831f3c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   85.20%   84.80%   -0.40%     
==========================================
  Files         930      930              
  Lines      154236   154234       -2     
==========================================
- Hits       131416   130802     -614     
- Misses      22820    23432     +612     

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 27, 2024
Merged via the queue into GreptimeTeam:main with commit 5fa01e7 Mar 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants