Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds metric engine to information_schema engines table #3599

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

killme2008
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Adds metric engine to information_schema engines table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@killme2008 killme2008 marked this pull request as ready for review March 27, 2024 19:39
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (92a8e86) to head (912fa7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3599      +/-   ##
==========================================
- Coverage   85.35%   84.97%   -0.38%     
==========================================
  Files         931      931              
  Lines      154611   154612       +1     
==========================================
- Hits       131961   131389     -572     
- Misses      22650    23223     +573     

@tisonkun tisonkun added this pull request to the merge queue Mar 28, 2024
Merged via the queue into GreptimeTeam:main with commit 5d7ce08 Mar 28, 2024
18 checks passed
@killme2008 killme2008 deleted the feature/add-metric-engine branch March 28, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants