Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust status code to http error code map #3601

Merged
merged 2 commits into from Mar 28, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Mar 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Move some error types out of 500

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 28, 2024
@waynexia waynexia enabled auto-merge March 28, 2024 07:09
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia added this pull request to the merge queue Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (92a8e86) to head (25e817c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3601      +/-   ##
==========================================
- Coverage   85.35%   85.01%   -0.34%     
==========================================
  Files         931      931              
  Lines      154611   154625      +14     
==========================================
- Hits       131961   131451     -510     
- Misses      22650    23174     +524     

Merged via the queue into GreptimeTeam:main with commit 06a9052 Mar 28, 2024
18 checks passed
@waynexia waynexia deleted the adjust-error-map branch March 28, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants