Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support outputting various date styles for postgresql #3602

Merged
merged 5 commits into from Apr 1, 2024

Conversation

J0HN50N133
Copy link
Contributor

@J0HN50N133 J0HN50N133 commented Mar 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3442

What's changed and what's your intention?

Support outputting various date styles for postgresql

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change
    • Add wrapper type StylingDate and StylingDateTime to encode date into related style
    • Add a new field in ConfigurationVariables

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 28, 2024
@J0HN50N133
Copy link
Contributor Author

@MichaelScofield Could you review this pr?

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 76.34409% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 85.06%. Comparing base (f49cd0c) to head (3ba747e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
- Coverage   85.41%   85.06%   -0.36%     
==========================================
  Files         932      934       +2     
  Lines      155075   155479     +404     
==========================================
- Hits       132451   132251     -200     
- Misses      22624    23228     +604     

@J0HN50N133
Copy link
Contributor Author

@MichaelScofield any update?

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are solid.

@evenyag
Copy link
Contributor

evenyag commented Apr 1, 2024

@MichaelScofield I'm going to merge this. If you have any other suggestions, you could comment on this PR or the related issue.

@evenyag evenyag added this pull request to the merge queue Apr 1, 2024
Merged via the queue into GreptimeTeam:main with commit d6b2d1d Apr 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support outputting various date styles for postgresql
3 participants