Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(table): remove unused table requests #3603

Merged
merged 5 commits into from Mar 28, 2024
Merged

refactor(table): remove unused table requests #3603

merged 5 commits into from Mar 28, 2024

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Mar 28, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Remove CreateDatabaseRequest, CreateTableRequest, OpenTableRequest, DropTableRequest, and CloseTableRequest
  2. Turn the dependency of the scripts table on CreateTableRequest to CreateTableExpr

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@zhongzc
refactor(table): remove unused requests
c63f3d8 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 28, 2024
@zhongzc
update comments
748b96f 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
fix: clippy
44b2182 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc
Merge remote-tracking branch 'origin/main' into zhongzc/table-unused-…
8b7567b 
…requests
@zhongzc
fix: compile
24b30c1 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 28, 2024
Merged via the queue into GreptimeTeam:main with commit 63681f0 Mar 28, 2024
17 checks passed
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

@WenyXu WenyXu Awaiting requested review from WenyXu

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongzc @MichaelScofield @waynexia