Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(procedure): auto split large value to multiple values #3605

Merged
merged 15 commits into from Apr 1, 2024
Merged

feat(procedure): auto split large value to multiple values #3605

merged 15 commits into from Apr 1, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 28, 2024 •
edited

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

auto split large value into multiple values

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the Doc not needed This PR do not impact docs label Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 96.10028% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 85.04%. Comparing base (5addb7d) to head (c083b5d).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
- Coverage   85.36%   85.04%   -0.32%     
==========================================
  Files         931      935       +4     
  Lines      154702   156348    +1646     
==========================================
+ Hits       132065   132970     +905     
- Misses      22637    23378     +741

@WenyXu WenyXu force-pushed the feat/state-store-auto-split-v2 branch from ecb5775 to ac1dddb Compare March 29, 2024 03:49
fengjiachun
fengjiachun reviewed Mar 29, 2024
View reviewed changes
src/common/meta/src/state_store.rs Show resolved Hide resolved
src/common/meta/src/state_store.rs Show resolved Hide resolved
src/common/procedure/src/store.rs Outdated Show resolved Hide resolved
src/common/meta/src/state_store.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/state-store-auto-split-v2 branch from 17f4e5a to 1e0aa40 Compare March 29, 2024 07:09
fengjiachun
fengjiachun approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evenyag
evenyag reviewed Apr 1, 2024
View reviewed changes
src/common/meta/src/state_store.rs Show resolved Hide resolved
src/common/procedure/src/store/util.rs Outdated Show resolved Hide resolved
src/common/procedure/src/store/util.rs Outdated Show resolved Hide resolved
src/common/procedure/src/store/util.rs Outdated Show resolved Hide resolved
src/common/procedure/src/store/util.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/state-store-auto-split-v2 branch from d5e077f to 29594a3 Compare April 1, 2024 09:58
@WenyXu WenyXu requested a review from evenyag April 1, 2024 11:32
evenyag
evenyag approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/procedure/src/store/util.rs Outdated Show resolved Hide resolved
@WenyXu @evenyag
Update src/common/procedure/src/store/util.rs
c083b5d 
Co-authored-by: Yingwen <realevenyag@gmail.com>
@fengjiachun fengjiachun added this pull request to the merge queue Apr 1, 2024
Merged via the queue into GreptimeTeam:main with commit 6c316d2 Apr 1, 2024
18 checks passed
@tisonkun tisonkun mentioned this pull request Apr 9, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

Assignees
No one assigned
Labels
Doc not needed This PR do not impact docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WenyXu @fengjiachun @evenyag