Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group requests by peer #3619

Merged

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Minor improve, group the requests by datanode peer, it is good for this case: there are multiple regions of one table on the same datanode

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (f49cd0c) to head (d686782).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
- Coverage   85.41%   85.11%   -0.30%     
==========================================
  Files         932      932              
  Lines      155075   155148      +73     
==========================================
- Hits       132451   132056     -395     
- Misses      22624    23092     +468     

@fengys1996 fengys1996 self-requested a review April 1, 2024 03:01
Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengys1996 fengys1996 added this pull request to the merge queue Apr 1, 2024
Merged via the queue into GreptimeTeam:main with commit 0eb023b Apr 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants