feat: cluster information #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
commented
Apr 2, 2024
fengjiachun
commented
Apr 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
- Coverage 85.14% 84.80% -0.35%
==========================================
Files 943 946 +3
Lines 157092 157547 +455
==========================================
- Hits 133754 133604 -150
- Misses 23338 23943 +605 |
fengjiachun
force-pushed
the
feat/cluster-info
branch
3 times, most recently
from
544cceb
to
9f481e0
Compare
fengjiachun
force-pushed
the
feat/cluster-info
branch
from
c396c54
to
64f73a4
Compare
fengjiachun
force-pushed
the
feat/cluster-info
branch
from
23a5933
to
862a091
Compare
fengjiachun
force-pushed
the
feat/cluster-info
branch
from
862a091
to
d6f61f1
Compare
src/meta-srv/src/handler/collect_datanode_cluster_info_handler.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/handler/collect_frontend_cluster_info_handler.rs
Outdated
Show resolved
Hide resolved
killme2008
reviewed
Apr 8, 2024
src/meta-srv/src/handler/collect_datanode_cluster_info_handler.rs
Outdated
Show resolved
Hide resolved
|
The comments have all been resolved, please take a look @killme2008 @MichaelScofield |
fengjiachun
force-pushed
the
feat/cluster-info
branch
from
2db4342
to
40f5dd2
Compare
MichaelScofield
approved these changes
Apr 8, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Close #3294 , allow meta client to get some information of all nodes in the cluster, the implementation is divided into the following steps:
CollectDatanodeClusterInfoHandlerandCollectFrontendClusterInfoHandler, which are used to process heartbeats requests from datanodes and frontends. These handlers extract information and write it into the in-memory KV storage on the metasrv leader node.rangeandbatch_getAPIs.ClusterInfotrait for the cluster client, and implement thelist_nodesmethod based on the kv service to return information about all node states.Other: The information for the Metasrv node will not be included in this PR as it is about to exceed 1000 lines.
Checklist