Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mistakely removes compaction inputs on failure #3635

Merged
merged 3 commits into from Apr 3, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 3, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR fixes the the incorrect behavior that removes compaction inputs instead of outputs on compaction failure.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 92.43697% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 84.86%. Comparing base (d33435f) to head (c8ec6c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3635      +/-   ##
==========================================
- Coverage   85.16%   84.86%   -0.31%     
==========================================
  Files         943      943              
  Lines      156940   157048     +108     
==========================================
- Hits       133661   133271     -390     
- Misses      23279    23777     +498     

@evenyag
Copy link
Contributor

evenyag commented Apr 3, 2024

I added a test for this case #3636. If the test also fails in CI, I'll merge this PR into the main branch to make the test pass.

Well, I added the same test in #3636 to this PR.

test: add test for compaction failure
@v0y4g3r v0y4g3r requested a review from evenyag April 3, 2024 11:43
@evenyag evenyag enabled auto-merge April 3, 2024 11:46
@evenyag evenyag added this pull request to the merge queue Apr 3, 2024
Merged via the queue into GreptimeTeam:main with commit ddeb73f Apr 3, 2024
19 checks passed
MichaelScofield pushed a commit to MichaelScofield/greptimedb that referenced this pull request Apr 7, 2024
* fix: mistakely removes compaction inputs on failure

* test: add test for compaction failure

---------

Co-authored-by: evenyag <realevenyag@gmail.com>
@waynexia waynexia mentioned this pull request Apr 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compaction cleans input files instead of output files on failure
3 participants