Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor alter table procedure #3678

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3637

What's changed and what's your intention?

  1. Fetch the table info during the execution.
  2. Refactor alter table procedure
  3. Add mores tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 9, 2024
@WenyXu WenyXu marked this pull request as draft April 9, 2024 05:21
@WenyXu WenyXu force-pushed the refactor/alter-table-procedure branch from a1cb09b to b13ea1e Compare April 9, 2024 06:08
@WenyXu WenyXu marked this pull request as ready for review April 9, 2024 06:16
@WenyXu WenyXu force-pushed the refactor/alter-table-procedure branch from b13ea1e to b5ae710 Compare April 9, 2024 06:23
@WenyXu WenyXu force-pushed the refactor/alter-table-procedure branch from b5ae710 to 01772cd Compare April 9, 2024 06:47
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 97.70774% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.83%. Comparing base (50bea2f) to head (0a5f5c0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
- Coverage   85.18%   84.83%   -0.35%     
==========================================
  Files         951      955       +4     
  Lines      158906   158992      +86     
==========================================
- Hits       135368   134887     -481     
- Misses      23538    24105     +567     

src/common/meta/src/ddl/alter_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table/metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table/check.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table/check.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table/metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table/metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table.rs Show resolved Hide resolved
src/common/meta/src/ddl/alter_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/alter_table/update_metadata.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/tests/alter_table.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the refactor/alter-table-procedure branch from bb70285 to 2a3263e Compare April 9, 2024 09:19
@WenyXu
Copy link
Member Author

WenyXu commented Apr 9, 2024

@MichaelScofield @fengjiachun PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GreptimeTeam:main with commit fda1523 Apr 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter table procedure should fetch table info during the execution
3 participants