Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(flow): more comments&lint #3680

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Apr 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Just add bunch of comments and lints, also make function resolution for binary function carry correct signature now.

  • lint for functions with too many lines
  • comments for pub item
  • make function resolution for binary function carry correct signature(i.e. Eq with i32 now have signature with input type i32)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 41.13924% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (883b7fc) to head (9e0fe1b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3680      +/-   ##
==========================================
- Coverage   85.16%   84.80%   -0.36%     
==========================================
  Files         951      955       +4     
  Lines      158903   159099     +196     
==========================================
- Hits       135328   134931     -397     
- Misses      23575    24168     +593     

src/flow/src/repr/relation.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/Cargo.toml Outdated Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Apr 10, 2024
Merged via the queue into GreptimeTeam:main with commit c00c1d9 Apr 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants