Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop table procedure #3688

Merged
merged 2 commits into from Apr 10, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Fetch the table info & route during the execution
  2. Add mores tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the Doc not needed This PR do not impact docs label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 75.30864% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 84.75%. Comparing base (5d73993) to head (4532b20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3688      +/-   ##
==========================================
- Coverage   85.20%   84.75%   -0.45%     
==========================================
  Files         955      957       +2     
  Lines      158994   159154     +160     
==========================================
- Hits       135469   134894     -575     
- Misses      23525    24260     +735     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 10, 2024
Merged via the queue into GreptimeTeam:main with commit c1e005b Apr 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc not needed This PR do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants