-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flow): transform substrait SELECT&WHERE&GROUP BY to Flow Plan #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
==========================================
+ Coverage 85.14% 85.24% +0.09%
==========================================
Files 955 962 +7
Lines 159101 160264 +1163
==========================================
+ Hits 135463 136611 +1148
- Misses 23638 23653 +15 |
zhongzc
reviewed
Apr 10, 2024
zhongzc
reviewed
Apr 11, 2024
zhongzc
reviewed
Apr 11, 2024
zhongzc
reviewed
Apr 11, 2024
zhongzc
reviewed
Apr 11, 2024
zhongzc
reviewed
Apr 11, 2024
zhongzc
reviewed
Apr 11, 2024
zhongzc
reviewed
Apr 11, 2024
Almost LGTM. Awesome patch! |
zhongzc
reviewed
Apr 11, 2024
zhongzc
approved these changes
Apr 11, 2024
fengjiachun
approved these changes
Apr 12, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
What's changed and what's your intention?
Added some basic transform functions to transform from Substrait Plan to Flow Plan,
and add some testcase to cover most case currently impled(Please help me found more useful testcase)
SELECT
,WHERE
andGROUP BY
1+number*2/3%4>0
and simple constant foldingChecklist