Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): transform substrait SELECT&WHERE&GROUP BY to Flow Plan #3690

Merged
merged 8 commits into from
Apr 12, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Apr 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

What's changed and what's your intention?

Added some basic transform functions to transform from Substrait Plan to Flow Plan,
and add some testcase to cover most case currently impled(Please help me found more useful testcase)

  • support transform simple Substrait Plan including SELECT, WHERE and GROUP BY
  • support simple binary operators like 1+number*2/3%4>0 and simple constant folding
  • related tests are added(more tests are welcomed)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@discord9 discord9 changed the title feat: transform substrait SELECT&WHERE&GROUP BY to Flow Plan feat(flow): transform substrait SELECT&WHERE&GROUP BY to Flow Plan Apr 10, 2024
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 10, 2024
@discord9 discord9 requested a review from zhongzc April 10, 2024 07:33
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 75.11826% with 263 lines in your changes are missing coverage. Please review.

Project coverage is 85.24%. Comparing base (c00c1d9) to head (2712698).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3690      +/-   ##
==========================================
+ Coverage   85.14%   85.24%   +0.09%     
==========================================
  Files         955      962       +7     
  Lines      159101   160264    +1163     
==========================================
+ Hits       135463   136611    +1148     
- Misses      23638    23653      +15     

src/flow/src/transform.rs Outdated Show resolved Hide resolved
src/flow/src/transform.rs Outdated Show resolved Hide resolved
src/flow/Cargo.toml Outdated Show resolved Hide resolved
src/flow/src/transform.rs Outdated Show resolved Hide resolved
src/flow/src/transform.rs Outdated Show resolved Hide resolved
@discord9 discord9 requested review from waynexia and a team as code owners April 11, 2024 03:25
@zhongzc
Copy link
Contributor

zhongzc commented Apr 11, 2024

Almost LGTM. Awesome patch!

src/flow/src/transform.rs Outdated Show resolved Hide resolved
src/flow/src/expr/scalar.rs Show resolved Hide resolved
@fengjiachun fengjiachun added this pull request to the merge queue Apr 12, 2024
Merged via the queue into GreptimeTeam:main with commit db329f6 Apr 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants