Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CODEOWNERS file #3691

Merged
merged 1 commit into from
Apr 10, 2024
Merged

ci: add CODEOWNERS file #3691

merged 1 commit into from
Apr 10, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Everyone who has write permission can give binding (green) approval. We add some domain experts for special care on those modules to increase quality assurance.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (c00c1d9) to head (f8223d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
- Coverage   85.14%   85.12%   -0.02%     
==========================================
  Files         955      955              
  Lines      159101   159101              
==========================================
- Hits       135463   135435      -28     
- Misses      23638    23666      +28     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 9459ace Apr 10, 2024
20 checks passed
@sunng87 sunng87 deleted the CODEOWNERS branch April 10, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants