Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drop_table): support to rollback table metadata #3692

Merged
merged 24 commits into from
Apr 16, 2024
Merged

feat(drop_table): support to rollback table metadata #3692

merged 24 commits into from
Apr 16, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 10, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3615

What's changed and what's your intention?

  1. Introduce TombstoneManager
  2. Support to rollback table metadata in drop table procedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 10, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (c1e005b) to head (3a51e39).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3692      +/-   ##
==========================================
- Coverage   85.11%   85.11%   -0.01%     
==========================================
  Files         957      966       +9     
  Lines      159154   161729    +2575     
==========================================
+ Hits       135471   137651    +2180     
- Misses      23683    24078     +395

@WenyXu WenyXu marked this pull request as draft April 11, 2024 07:03
@WenyXu WenyXu marked this pull request as ready for review April 12, 2024 15:35
@WenyXu WenyXu requested a review from a team as a code owner April 12, 2024 15:35
@WenyXu WenyXu force-pushed the feat/drop-table-rollback branch 2 times, most recently from 8e0f0a8 to 69508df Compare April 15, 2024 08:49
@WenyXu
Copy link
Member Author

WenyXu commented Apr 15, 2024

PTAL @MichaelScofield @fengjiachun

MichaelScofield
MichaelScofield reviewed Apr 16, 2024
View reviewed changes
src/common/meta/src/ddl/drop_database/executor.rs Show resolved Hide resolved
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/tombstone.rs Show resolved Hide resolved
src/common/meta/src/key/tombstone.rs Show resolved Hide resolved
src/common/meta/src/key/tombstone.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/tombstone.rs Show resolved Hide resolved
fengjiachun
fengjiachun reviewed Apr 16, 2024
View reviewed changes
src/common/meta/src/ddl/drop_database/cursor.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/drop_database/executor.rs Outdated Show resolved Hide resolved
src/common/meta/src/key.rs Show resolved Hide resolved
src/common/meta/src/key.rs Show resolved Hide resolved
src/common/meta/src/key.rs Show resolved Hide resolved
src/common/meta/src/ddl/drop_table/executor.rs Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
tests/cases/standalone/common/create/create_metric_table.sql Show resolved Hide resolved
src/common/meta/src/key.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/drop_table.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Apr 16, 2024

@MichaelScofield @fengjiachun PTAL

fengjiachun
fengjiachun approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

MichaelScofield
MichaelScofield approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@MichaelScofield MichaelScofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is too large, the remaining comments can be resolved in the following PRs.

src/common/meta/src/ddl/drop_database/executor.rs Show resolved Hide resolved
@WenyXu WenyXu added this pull request to the merge queue Apr 16, 2024
Merged via the queue into GreptimeTeam:main with commit d123791 Apr 16, 2024
22 checks passed
@WenyXu WenyXu deleted the feat/drop-table-rollback branch April 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore the metadata if dropping table failed
3 participants
@WenyXu @MichaelScofield @fengjiachun