Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check partition rule #3711

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Apr 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3351

What's changed and what's your intention?

Check the input partition rule set to make sure there is no cavity.

I'll file a follow-up PR to refactor the partition crate to remove the old implementation and install the new one directly (without a trait indirection).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia requested a review from a team as a code owner April 15, 2024 12:34
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 15, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 88.37209% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (2f4726f) to head (0bb197b).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3711      +/-   ##
==========================================
- Coverage   85.47%   85.11%   -0.37%     
==========================================
  Files         963      965       +2     
  Lines      160455   161322     +867     
==========================================
+ Hits       137154   137314     +160     
- Misses      23301    24008     +707     

src/partition/src/multi_dim.rs Show resolved Hide resolved
src/partition/src/multi_dim.rs Outdated Show resolved Hide resolved
src/partition/src/multi_dim.rs Outdated Show resolved Hide resolved
src/partition/src/multi_dim.rs Outdated Show resolved Hide resolved
src/partition/src/multi_dim.rs Outdated Show resolved Hide resolved
src/partition/src/multi_dim.rs Outdated Show resolved Hide resolved
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia enabled auto-merge April 16, 2024 07:11
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Apr 16, 2024
Merged via the queue into GreptimeTeam:main with commit 96a40e0 Apr 16, 2024
19 checks passed
@waynexia waynexia deleted the check-partition-rule branch April 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants