-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(meta): Ensure all moving values remain unchanged between two transactions #3727
refactor(meta): Ensure all moving values remain unchanged between two transactions #3727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this refactor?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 85.44% 85.15% -0.29%
==========================================
Files 966 966
Lines 162087 162094 +7
==========================================
- Hits 138496 138034 -462
- Misses 23591 24060 +469 |
For moving value to tombstone values operation, it ensures all values remain unchanged between two transactions instead of a single value in the previous version. |
30f300a
to
03b6af6
Compare
03b6af6
to
099b24c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your
move_values
inTombstoneManager
delete_table_metadata
andrestore_table_metadata
to be Idempotent.Checklist