Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(flow): split render.rs and other minor changes #3750

Merged
merged 5 commits into from
Apr 22, 2024
Merged

refactor(flow): split render.rs and other minor changes #3750

merged 5 commits into from
Apr 22, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

As titile says, some minor refactor and doc improvement in flow module

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 19, 2024
@discord9 discord9 marked this pull request as ready for review April 19, 2024 09:09
@discord9 discord9 requested review from zhongzc, waynexia and a team as code owners April 19, 2024 09:09
@discord9 discord9 requested review from zhongzc and removed request for zhongzc April 19, 2024 09:09
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.87879% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 85.19%. Comparing base (cfed466) to head (0f359cf).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3750      +/-   ##
==========================================
- Coverage   85.63%   85.19%   -0.45%     
==========================================
  Files         944      946       +2     
  Lines      158776   159555     +779     
==========================================
- Hits       135966   135928      -38     
- Misses      22810    23627     +817

waynexia
waynexia approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/flow/src/utils.rs Outdated Show resolved Hide resolved
src/flow/src/utils.rs Outdated Show resolved Hide resolved
src/flow/src/expr/error.rs Outdated Show resolved Hide resolved
src/flow/src/compute/render.rs Outdated Show resolved Hide resolved
@discord9 discord9 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into GreptimeTeam:main with commit d4b814f Apr 22, 2024
19 checks passed
@discord9 discord9 deleted the flow_p3_render_refactor branch April 22, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@zhongzc zhongzc zhongzc approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@discord9 @waynexia @zhongzc