Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the dropping_regions guards should be dropped on procedure done #3771

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The failed sqlness test shows that there might be some data race on dropping tables:

image

After digging into the codes, I think the problem is caused by the implementation that the procedure returned does not mean it's dropped. The logs suggest the same:

image

This PR fix it.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@MichaelScofield MichaelScofield requested a review from a team as a code owner April 22, 2024 12:21
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.20%. Comparing base (7ca0fa5) to head (9848cbc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3771      +/-   ##
==========================================
- Coverage   85.51%   85.20%   -0.32%     
==========================================
  Files         946      946              
  Lines      159555   159566      +11     
==========================================
- Hits       136446   135953     -493     
- Misses      23109    23613     +504     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 23, 2024
Merged via the queue into GreptimeTeam:main with commit 96c01a3 Apr 23, 2024
19 checks passed
@MichaelScofield MichaelScofield deleted the fix/drop-region-guard branch April 23, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants