-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: use the right precision #3794
Merged
fengjiachun
merged 7 commits into
GreptimeTeam:main
from
fengjiachun:fix/time-precision
Apr 25, 2024
Merged
fix!: use the right precision #3794
fengjiachun
merged 7 commits into
GreptimeTeam:main
from
fengjiachun:fix/time-precision
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking-change
This pull request contains breaking changes.
docs-not-required
This change does not impact docs.
labels
Apr 24, 2024
Don't forget comments for pub functions/structures. |
tisonkun
reviewed
Apr 24, 2024
etolbakov
reviewed
Apr 24, 2024
fengjiachun
force-pushed
the
fix/time-precision
branch
from
April 24, 2024 11:05
5fa723a
to
0f1a9f8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3794 +/- ##
==========================================
- Coverage 85.56% 85.25% -0.32%
==========================================
Files 947 946 -1
Lines 161503 161142 -361
==========================================
- Hits 138198 137384 -814
- Misses 23305 23758 +453 |
fengjiachun
force-pushed
the
fix/time-precision
branch
from
April 24, 2024 15:29
0e3b21a
to
97c4a5f
Compare
yuanbohan
approved these changes
Apr 25, 2024
killme2008
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
This pull request contains breaking changes.
docs-not-required
This change does not impact docs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Use the right precision.
Before: The data written with Influxdb line protocol before was stored as type
Millisecond
, resulting in loss of precision.After: The data written with influxes line protocol and OTLP protocol will be stored as type "Nanosecond"
Note that this is a breaking change because the data storage type has changed from
Millisecond
toNanosecond
. For existing tables, new writes will result in an error. One solution is to delete the data and re-import it.Others:
writer.rs
andline_writer.rs
since we do not need them any more(There were for column protocol)Checklist