Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define CreateFlowTask and DropFlowTask #3801

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 25, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Define CreateFlowTask and DropFlowTask.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners April 25, 2024 11:48
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 6.00000% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (2d0f493) to head (cacd886).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3801      +/-   ##
==========================================
- Coverage   85.62%   85.30%   -0.32%     
==========================================
  Files         947      953       +6     
  Lines      161925   162881     +956     
==========================================
+ Hits       138647   138953     +306     
- Misses      23278    23928     +650     

@waynexia waynexia enabled auto-merge April 25, 2024 12:09
@waynexia waynexia added this pull request to the merge queue Apr 25, 2024
@waynexia waynexia removed this pull request from the merge queue due to a manual request Apr 25, 2024
@WenyXu WenyXu enabled auto-merge April 25, 2024 12:16
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue Apr 25, 2024
Merged via the queue into GreptimeTeam:main with commit 1ec5951 Apr 25, 2024
19 checks passed
@WenyXu WenyXu deleted the feat/define-struct branch April 25, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants