Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register regions during procedure recovery #3859

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Ensures all operating regions are registered during procedure recovery.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 85.54217% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (5303537) to head (656ba75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3859      +/-   ##
==========================================
- Coverage   85.57%   85.30%   -0.28%     
==========================================
  Files         952      952              
  Lines      163062   163215     +153     
==========================================
- Hits       139543   139228     -315     
- Misses      23519    23987     +468     

@WenyXu WenyXu requested a review from fengjiachun May 6, 2024 06:17
@WenyXu WenyXu marked this pull request as draft May 6, 2024 07:45
@WenyXu WenyXu marked this pull request as ready for review May 6, 2024 08:48
@WenyXu WenyXu force-pushed the fix/register-region-during-procedure-recovery branch from c15989a to 50c2a19 Compare May 6, 2024 08:52
@WenyXu
Copy link
Member Author

WenyXu commented May 6, 2024

@fengjiachun @MichaelScofield PTAL

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue May 7, 2024
Merged via the queue into GreptimeTeam:main with commit 1b58622 May 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants