Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Plugins to plugins.rs and use rwlock #3862

Merged
merged 2 commits into from
May 7, 2024

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

It's a minor refactoring for Plugins to make it clean.

In this PR:

  1. Move Plugins from lib.rs to the new mod file plugins.rs;
  2. Add some simple and necessary unit tests for Plugins;
  3. Use RwLock instead of Mutex to improve performance;

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@zyy17 zyy17 requested a review from a team as a code owner May 6, 2024 09:45
@zyy17 zyy17 requested a review from shuiyisong May 6, 2024 09:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.31%. Comparing base (6e1cc1d) to head (f038057).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
- Coverage   85.64%   85.31%   -0.33%     
==========================================
  Files         952      952              
  Lines      163290   163334      +44     
==========================================
- Hits       139843   139351     -492     
- Misses      23447    23983     +536     

@zyy17 zyy17 force-pushed the refactor/add-plugins-rs branch 2 times, most recently from d153411 to 6febba8 Compare May 6, 2024 13:34
@zyy17 zyy17 force-pushed the refactor/add-plugins-rs branch from 6febba8 to 3399793 Compare May 7, 2024 09:23
@zyy17 zyy17 requested a review from shuiyisong May 7, 2024 09:24
@zyy17 zyy17 changed the title refactor: move Plugins to plugins.rs and add unit tests refactor: move Plugins to plugins.rs and use rwlock May 7, 2024
@zyy17 zyy17 force-pushed the refactor/add-plugins-rs branch from 3399793 to 03e16d7 Compare May 7, 2024 10:56
@zyy17 zyy17 requested a review from sunng87 May 7, 2024 11:10
@zyy17 zyy17 force-pushed the refactor/add-plugins-rs branch from 03e16d7 to f038057 Compare May 7, 2024 11:59
@tisonkun tisonkun added this pull request to the merge queue May 7, 2024
Merged via the queue into GreptimeTeam:main with commit cc8d6b1 May 7, 2024
21 checks passed
@zyy17 zyy17 deleted the refactor/add-plugins-rs branch May 8, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants