Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pprof): import common_telemetry::info #3870

Closed
wants to merge 1 commit into from

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3865

What's changed and what's your intention?

Missing items while executing cargo build --bin greptime --features=pprof

   Compiling cmd v0.7.2 (/home/weny/Projects/greptimedb/src/cmd)
   Compiling servers v0.7.2 (/home/weny/Projects/greptimedb/src/servers)
error: cannot find macro `info` in this scope
  --> src/servers/src/http/pprof.rs:66:9
   |
66 |         info!("start pprof, request: {:?}", req);
   |         ^^^^
   |
help: consider importing one of these items
   |
20 +     use common_telemetry::info;
   |
20 +     use crate::http::info;
   |

Import common_telemetry::info for pprof.rs

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 7, 2024 03:09
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 7, 2024
@WenyXu WenyXu requested a review from waynexia May 7, 2024 03:10
@tisonkun
Copy link
Contributor

tisonkun commented May 7, 2024

Duplicate of #3868.

@tisonkun tisonkun closed this May 7, 2024
@WenyXu WenyXu requested a review from evenyag May 7, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants