Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metasrvs nodeinfo #3873

Merged
merged 4 commits into from
May 7, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented May 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Allow to get metsrvs' node info (version and git_commit).

proto: GreptimeTeam/greptime-proto#163

Closes: #3843

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested review from MichaelScofield and a team as code owners May 7, 2024 08:19
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 85.29%. Comparing base (154f561) to head (902c072).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3873      +/-   ##
==========================================
- Coverage   85.60%   85.29%   -0.31%     
==========================================
  Files         952      952              
  Lines      163079   163290     +211     
==========================================
- Hits       139596   139283     -313     
- Misses      23483    24007     +524     

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/meta-srv/src/election/etcd.rs Outdated Show resolved Hide resolved
@MichaelScofield MichaelScofield added this pull request to the merge queue May 7, 2024
@fengjiachun fengjiachun removed this pull request from the merge queue due to a manual request May 7, 2024
@fengjiachun fengjiachun enabled auto-merge May 7, 2024 11:05
@fengjiachun fengjiachun added this pull request to the merge queue May 7, 2024
Merged via the queue into GreptimeTeam:main with commit 6e1cc1d May 7, 2024
22 checks passed
@fengjiachun fengjiachun deleted the feat/metasrv-nodeinfo branch May 7, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve the metasrv node info in meta-client
3 participants