Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logstore): remove Entry::namemspace #3875

Merged

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented May 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • Remove Entry::namespace method and related asscoiated type.
  • Fix the estimated size logic to computing the encoded length of entries.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

… types on Entry.

Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 7, 2024
@v0y4g3r v0y4g3r requested a review from waynexia May 7, 2024 11:40
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Entry::namespace()?

@tisonkun
Copy link
Contributor

tisonkun commented May 7, 2024

And create_namespace, delete_namespace, list_namespaces is unused also.

I suppose if we'd want to use the namespace encapsulation, we should use the Namespace type/trait, instead of pub ns: NamespaceImpl.

Otherwise, drop the whole namespace design and inline the concat namespace on demand.

@v0y4g3r v0y4g3r changed the title refactor(logstore): remove LogStore::namemspace refactor(logstore): remove Entry::namemspace May 7, 2024
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I'd prefer to declare our plan to the Namespace abstraction first and avoid directly access ns field if we'd hold this abstraction.

BTW, NoopLogStore is never used even in tests. We can remove it in a following PR since it is totally useless (the associated tests is noop actually).

@v0y4g3r v0y4g3r added this pull request to the merge queue May 8, 2024
Merged via the queue into GreptimeTeam:main with commit c07a1ba May 8, 2024
25 checks passed
@v0y4g3r v0y4g3r deleted the refactor/remove-namespace-in-logstore branch May 8, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants