Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement drop flow procedure #3877

Merged
merged 8 commits into from
May 9, 2024
Merged

feat: implement drop flow procedure #3877

merged 8 commits into from
May 9, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3664

What's changed and what's your intention?

  1. implement the drop flow procedure
  2. Add FlowNotFound and FlowAlteadyExists to StateCode
  3. Add tests for create flow and drop flow procedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners May 7, 2024 12:40
@WenyXu WenyXu requested a review from fengjiachun May 7, 2024 12:40
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 7, 2024
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

Attention: Patch coverage is 80.88643% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 85.48%. Comparing base (5140d24) to head (c3c9b58).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3877      +/-   ##
==========================================
- Coverage   85.62%   85.48%   -0.14%     
==========================================
  Files         952      954       +2     
  Lines      163685   163940     +255     
==========================================
- Hits       140149   140147       -2     
- Misses      23536    23793     +257

fengjiachun
fengjiachun reviewed May 8, 2024
View reviewed changes
src/common/meta/src/ddl/drop_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/drop_flow.rs Outdated Show resolved Hide resolved
MichaelScofield
MichaelScofield reviewed May 8, 2024
View reviewed changes
src/common/error/src/status_code.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/flow.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the feat/drop-flow-procedure branch from 1c80360 to 728373d Compare May 9, 2024 06:37
fengjiachun
fengjiachun approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some conflicts @WenyXu

@WenyXu WenyXu enabled auto-merge May 9, 2024 08:11
@WenyXu WenyXu added this pull request to the merge queue May 9, 2024
Merged via the queue into GreptimeTeam:main with commit 5545a8b May 9, 2024
22 checks passed
@WenyXu WenyXu deleted the feat/drop-flow-procedure branch May 9, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WenyXu @MichaelScofield @fengjiachun