-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement CacheContainer
& TableFlownodeSetCache
#3885
Conversation
Can you explain what it is? What problem does it solve? @WenyXu |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
==========================================
- Coverage 85.63% 85.47% -0.17%
==========================================
Files 952 956 +4
Lines 163341 164270 +929
==========================================
+ Hits 139878 140405 +527
- Misses 23463 23865 +402 |
Description updated |
AdvancedCache
AdvancedCache
& TableFlownodeSetCache
AdvancedCache
& TableFlownodeSetCache
CacheContainer
& TableFlownodeSetCache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
CacheContainer
TableFlownodeSetCache
CacheContainer
Currently, the Cache on Frontend is provided by
CachedKvBackend
. There are currently two problems:The
CacheContainer
aims to resolve the above problems. It's able to cache arbitrary structures.Checklist