Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement CacheContainer & TableFlownodeSetCache #3885

Merged
merged 13 commits into from
May 9, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Introduce CacheContainer
  2. Implement the TableFlownodeSetCache

CacheContainer

Currently, the Cache on Frontend is provided by CachedKvBackend. There are currently two problems:

  1. Upper-layer calls still have additional decoding overhead.
  2. Unable to cache Range Query

The CacheContainer aims to resolve the above problems. It's able to cache arbitrary structures.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners May 8, 2024 11:50
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 8, 2024
@fengjiachun
Copy link
Collaborator

Can you explain what it is? What problem does it solve? @WenyXu

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 93.35347% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 85.47%. Comparing base (cc8d6b1) to head (8ad0b44).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3885      +/-   ##
==========================================
- Coverage   85.63%   85.47%   -0.17%     
==========================================
  Files         952      956       +4     
  Lines      163341   164270     +929     
==========================================
+ Hits       139878   140405     +527     
- Misses      23463    23865     +402     

@WenyXu
Copy link
Member Author

WenyXu commented May 8, 2024

Can you explain what it is? What problem does it solve? @WenyXu

Description updated

@WenyXu WenyXu requested a review from fengjiachun May 8, 2024 12:28
@WenyXu WenyXu changed the title feat: implement AdvancedCache feat: implement AdvancedCache & TableFlownodeSetCache May 8, 2024
@WenyXu WenyXu changed the title feat: implement AdvancedCache & TableFlownodeSetCache feat: implement CacheContainer & TableFlownodeSetCache May 8, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/meta/src/cache/container.rs Show resolved Hide resolved
@WenyXu WenyXu requested a review from zhongzc May 9, 2024 08:14
@WenyXu WenyXu enabled auto-merge May 9, 2024 09:11
@WenyXu WenyXu added this pull request to the merge queue May 9, 2024
Merged via the queue into GreptimeTeam:main with commit b8a325d May 9, 2024
22 checks passed
@WenyXu WenyXu deleted the feat/adv-cache branch May 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants