Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement drop flow parser #3888

Merged
merged 3 commits into from
May 9, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Implement Drop Flow statement parser

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 9, 2024 03:35
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 9, 2024
src/sql/src/parsers/drop_parser.rs Outdated Show resolved Hide resolved
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 89.60000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.31%. Comparing base (a6a702d) to head (97500e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3888      +/-   ##
==========================================
- Coverage   85.63%   85.31%   -0.33%     
==========================================
  Files         952      952              
  Lines      163496   163730     +234     
==========================================
- Hits       140017   139690     -327     
- Misses      23479    24040     +561     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 9, 2024
Merged via the queue into GreptimeTeam:main with commit 5140d24 May 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants