Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to drop flow #3900

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Support to drop flow

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners May 10, 2024 06:19
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 10, 2024
@WenyXu WenyXu requested a review from fengjiachun May 10, 2024 06:20
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 85.68%. Comparing base (c91132b) to head (d70cb1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3900      +/-   ##
==========================================
- Coverage   86.05%   85.68%   -0.37%     
==========================================
  Files         959      959              
  Lines      164279   164320      +41     
==========================================
- Hits       141367   140805     -562     
- Misses      22912    23515     +603     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@fengjiachun fengjiachun added this pull request to the merge queue May 10, 2024
@fengjiachun fengjiachun removed this pull request from the merge queue due to a manual request May 10, 2024
@fengjiachun fengjiachun added this pull request to the merge queue May 10, 2024
Merged via the queue into GreptimeTeam:main with commit 06e1c43 May 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants