Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce TableRouteCache to PartitionRuleManager #3922

Merged
merged 14 commits into from
May 13, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your

Introduce TableRouteCache to PartitionRuleManager to reduce overhead of deserializing cached bytes into TableRoute.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 11, 2024
@WenyXu WenyXu force-pushed the feat/partition-rule-mgr-cache branch from d5b7a23 to ab505a1 Compare May 11, 2024 14:22
@WenyXu WenyXu changed the title chore: add CompositeTableRouteCacheRef to PartitionRuleManager feat: introduce CompositeTableRouteCache to PartitionRuleManager May 13, 2024
@WenyXu WenyXu marked this pull request as ready for review May 13, 2024 02:25
@WenyXu WenyXu requested review from MichaelScofield and a team as code owners May 13, 2024 02:25
@WenyXu WenyXu requested a review from fengjiachun May 13, 2024 02:27
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 84.01487% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (590aedd) to head (f212ef1).
Report is 6 commits behind head on main.

❗ Current head f212ef1 differs from pull request most recent head a441f2f. Consider uploading reports for the commit a441f2f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3922      +/-   ##
==========================================
- Coverage   86.00%   85.65%   -0.36%     
==========================================
  Files         963      963              
  Lines      164516   164789     +273     
==========================================
- Hits       141498   141152     -346     
- Misses      23018    23637     +619     

src/common/meta/src/cache/container.rs Show resolved Hide resolved
src/partition/src/error.rs Outdated Show resolved Hide resolved
src/common/meta/src/cache/container.rs Show resolved Hide resolved
@fengjiachun fengjiachun requested a review from waynexia May 13, 2024 03:39
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me. But I'm not sure about other underlying logics (like who should use the cache but not, or who should invalid the cache but not). PTAL @fengjiachun

@WenyXu WenyXu marked this pull request as draft May 13, 2024 08:22
@WenyXu WenyXu marked this pull request as ready for review May 13, 2024 09:07
@fengjiachun
Copy link
Collaborator

The changes looks good to me. But I'm not sure about other underlying logics (like who should use the cache but not, or who should invalid the cache but not). PTAL @fengjiachun

I'm o_O ing

@WenyXu WenyXu marked this pull request as draft May 13, 2024 10:56
@WenyXu WenyXu changed the title feat: introduce CompositeTableRouteCache to PartitionRuleManager feat: introduce TableRouteCache to PartitionRuleManager May 13, 2024
@WenyXu WenyXu marked this pull request as ready for review May 13, 2024 11:16
@fengjiachun fengjiachun added this pull request to the merge queue May 13, 2024
Merged via the queue into GreptimeTeam:main with commit e15294d May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants