Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to invalidate flow cache #3926

Merged
merged 3 commits into from
May 14, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 13, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Invalidate flow cache in the create flow procedure
  2. Invalidate flow cache in the drop flow procedure

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 13, 2024
@WenyXu WenyXu marked this pull request as ready for review May 13, 2024 09:57
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 72.30769% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 85.47%. Comparing base (6ab3aeb) to head (dc46444).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3926      +/-   ##
==========================================
- Coverage   86.00%   85.47%   -0.53%     
==========================================
  Files         963      965       +2     
  Lines      164516   165107     +591     
==========================================
- Hits       141489   141131     -358     
- Misses      23027    23976     +949     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/meta/src/ddl/create_flow.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu enabled auto-merge May 14, 2024 06:09
@WenyXu WenyXu added this pull request to the merge queue May 14, 2024
Merged via the queue into GreptimeTeam:main with commit f16ce3c May 14, 2024
22 checks passed
@WenyXu WenyXu deleted the feat/flow-invalidate-cache branch May 14, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants