Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore internal columns in SHOW CREATE TABLE #3950

Merged
merged 4 commits into from
May 16, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Ignore internal columns in SHOW CREATE TABLE. But, we still print the internal columns in information_schema(it's by design).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested review from evenyag and a team as code owners May 15, 2024 13:44
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.34%. Comparing base (cfae276) to head (e3d690a).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3950      +/-   ##
==========================================
- Coverage   85.70%   85.34%   -0.37%     
==========================================
  Files         969      973       +4     
  Lines      166649   166863     +214     
==========================================
- Hits       142834   142410     -424     
- Misses      23815    24453     +638     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restly LGTM

src/query/src/sql/show_create_table.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu requested a review from v0y4g3r as a code owner May 16, 2024 02:55
@waynexia waynexia added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit dff7ba7 May 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants