Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): flow node manager #3954

Merged
merged 3 commits into from
May 16, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Build flownode in standalone mode, allow flow create

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Added flow node mangager, which impl flownode trait
  • Also impl grpc service trait for it

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 16, 2024
@discord9 discord9 marked this pull request as ready for review May 16, 2024 04:17
@discord9 discord9 requested review from zhongzc, waynexia and a team as code owners May 16, 2024 04:17
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 33.09693% with 566 lines in your changes are missing coverage. Please review.

Project coverage is 85.05%. Comparing base (9f4a6c6) to head (ece07ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3954      +/-   ##
==========================================
- Coverage   85.64%   85.05%   -0.59%     
==========================================
  Files         973      978       +5     
  Lines      167045   167873     +828     
==========================================
- Hits       143073   142792     -281     
- Misses      23972    25081    +1109     

src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Show resolved Hide resolved
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Outdated Show resolved Hide resolved
src/flow/src/adapter.rs Show resolved Hide resolved
feat(flow): render src/sink

feat(flow): flow node manager in standalone

fix?: higher run freq

chore: remove abunant error enum variant

fix: run with higher freq if insert more

chore: fix after rebase

chore: typos
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu mentioned this pull request May 16, 2024
13 tasks
@fengjiachun fengjiachun added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit 0d9e71b May 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants