Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: report CI failures with creating issues #3976

Merged
merged 3 commits into from
May 18, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Create a new issue on CI failure, or comment on an existing issue.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested a review from a team as a code owner May 17, 2024 09:03
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 17, 2024
Signed-off-by: tison <wander4096@gmail.com>
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (4b03045) to head (a690a6e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3976      +/-   ##
==========================================
- Coverage   85.41%   85.10%   -0.31%     
==========================================
  Files         978      978              
  Lines      168279   168436     +157     
==========================================
- Hits       143730   143349     -381     
- Misses      24549    25087     +538     

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels awesome to me 😊

@sunng87 sunng87 added this pull request to the merge queue May 18, 2024
@sunng87
Copy link
Member

sunng87 commented May 18, 2024

awesome. I worried about this could spam our issue tracker and it checks for duplicates.

Merged via the queue into GreptimeTeam:main with commit 11ad5b3 May 18, 2024
20 checks passed
@tisonkun
Copy link
Contributor Author

Actually I wrote the code on the airplane so I suppose there can be some corner cases I don't think carefully. But I'll keep an eye on this and ensure the workflow converge to work properly 🤣

@tisonkun tisonkun deleted the create-issue-for-ci-failure branch May 18, 2024 03:26
WenyXu pushed a commit to WenyXu/greptimedb that referenced this pull request May 21, 2024
* ci: report CI failures with creating issues

Signed-off-by: tison <wander4096@gmail.com>

* integrate with CI workflows

Signed-off-by: tison <wander4096@gmail.com>

* mention db-approver

Signed-off-by: tison <wander4096@gmail.com>

---------

Signed-off-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants