Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace Expr with datafusion::Expr #3995

Merged
merged 3 commits into from
May 21, 2024
Merged

refactor: replace Expr with datafusion::Expr #3995

merged 3 commits into from
May 21, 2024

Conversation

realtaobo
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

as title, part of #3884

What's changed and what's your intention?

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@realtaobo realtaobo marked this pull request as ready for review May 21, 2024 02:49
@realtaobo realtaobo requested review from waynexia, v0y4g3r, evenyag and a team as code owners May 21, 2024 02:49
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 21, 2024
@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.95775% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.15%. Comparing base (179c8c7) to head (2df231a).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
- Coverage   85.48%   85.15%   -0.33%     
==========================================
  Files         977      977              
  Lines      169348   169323      -25     
==========================================
- Hits       144773   144195     -578     
- Misses      24575    25128     +553

evenyag
evenyag reviewed May 21, 2024
View reviewed changes
src/metric-engine/Cargo.toml Outdated Show resolved Hide resolved
src/catalog/src/information_schema/predicate.rs Outdated Show resolved Hide resolved
src/metric-engine/src/engine/read.rs Outdated Show resolved Hide resolved
@evenyag evenyag mentioned this pull request May 21, 2024
Open
6 tasks
evenyag
evenyag approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! @realtaobo I have linked this PR to the issue's task list.

waynexia
waynexia approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still many alias DfExpr, but this PR is good to go

@waynexia waynexia added this pull request to the merge queue May 21, 2024
Merged via the queue into GreptimeTeam:main with commit 40c5858 May 21, 2024
20 checks passed
@realtaobo realtaobo deleted the renum branch May 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@waynexia waynexia waynexia approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r v0y4g3r is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@realtaobo @evenyag @waynexia