Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opertor): check if a database is in use before dropping it #4035

Merged
merged 1 commit into from
May 27, 2024

Conversation

etolbakov
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4029

What's changed and what's your intention?

check if a database/schema is in use before dropping it.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@etolbakov etolbakov requested a review from a team as a code owner May 24, 2024 12:20
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (5df3d4e) to head (9e1cd09).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
- Coverage   85.42%   85.12%   -0.31%     
==========================================
  Files         983      983              
  Lines      170493   170493              
==========================================
- Hits       145652   145139     -513     
- Misses      24841    25354     +513     

@etolbakov
Copy link
Collaborator Author

@killme2008 @waynexia
Could you please take a look when you have free time?

also I'm not sure I understand why "CI / Unstable Fuzz Test (unstable_fuzz_create_table_standalone)" is failing if you could point me out I'll be very grateful 🙏

@WenyXu
Copy link
Member

WenyXu commented May 25, 2024

@killme2008 @waynexia Could you please take a look when you have free time?

also I'm not sure I understand why "CI / Unstable Fuzz Test (unstable_fuzz_create_table_standalone)" is failing if you could point me out I'll be very grateful 🙏

The fuzz test will drop in-use database(public). Maybe we can create another database for testing instead of dropping the public directly?

@etolbakov
Copy link
Collaborator Author

Thank you Ruihang! I assume the rest is looks ok?

@WenyXu
Copy link
Member

WenyXu commented May 26, 2024

Thank you Ruihang! I assume the rest is looks ok?

LGTM, But @waynexia he is Ruihang🤣

@etolbakov
Copy link
Collaborator Author

ohhhh....sorry Weny!!!!
My eyes played trick on me 😄 I really believed that Ruihang replied 🙈
My bad!

I would try tackling the test in the next couple of days

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

@WenyXu There is a fuzz test failure
https://github.com/GreptimeTeam/greptimedb/actions/runs/9223815158/job/25388925971?pr=4035

@waynexia waynexia added this pull request to the merge queue May 27, 2024
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to @waynexia 😋

Merged via the queue into GreptimeTeam:main with commit af486ec May 27, 2024
29 of 30 checks passed
@etolbakov etolbakov deleted the check-if-db-in-use branch May 27, 2024 09:30
@etolbakov
Copy link
Collaborator Author

@WenyXu There is a fuzz test failure https://github.com/GreptimeTeam/greptimedb/actions/runs/9223815158/job/25388925971?pr=4035

Many thanks to @WenyXu for fixing the failing test 🙏
Linking the PR for the sake of the context.
#4049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants