Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric-engine): missing catchup implementation #4048

Merged
merged 2 commits into from
May 27, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 27, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add catchup implementation for metric engine

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from fengjiachun May 27, 2024 03:20
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (25d6425) to head (61aa873).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4048      +/-   ##
==========================================
- Coverage   85.44%   85.11%   -0.34%     
==========================================
  Files         983      985       +2     
  Lines      170505   170515      +10     
==========================================
- Hits       145695   145133     -562     
- Misses      24810    25382     +572     

@WenyXu WenyXu enabled auto-merge May 27, 2024 07:48
@WenyXu WenyXu added this pull request to the merge queue May 27, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into GreptimeTeam:main with commit 20ce7d4 May 27, 2024
27 of 28 checks passed
@WenyXu WenyXu deleted the fix/missing-cacthup branch May 27, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants