Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump datafusion 20240528 #4061

Merged
merged 13 commits into from
Jun 1, 2024
Merged

build(deps): bump datafusion 20240528 #4061

merged 13 commits into from
Jun 1, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented May 28, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Update datafusion to get substrait interval support. Also includes some upstream optimization to reduce clones.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia
build(deps): bump datafusion 20240528
315e0ea 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 28, 2024
This was referenced May 28, 2024
Closed
Merged
@waynexia
another update
4763622 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
update expected sqlness result
e85702b 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
fix first/last value
a5b727d 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
reformat comment
a226043 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
fix remaining errors
e8f670a 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
Merge branch 'main' into bump-datafusion-37
3aedbfd 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia marked this pull request as ready for review May 29, 2024 12:21
@waynexia waynexia requested review from evenyag and a team as code owners May 29, 2024 12:21
@waynexia
revert toml format
fd461fe 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
fix pyo3 feature
d8242eb 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.41718% with 116 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (fcfcf86) to head (ce44f10).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
- Coverage   85.53%   85.17%   -0.37%     
==========================================
  Files         991      991              
  Lines      172933   172968      +35     
==========================================
- Hits       147925   147325     -600     
- Misses      25008    25643     +635

@waynexia
Merge branch 'main' into bump-datafusion-37
731f864 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
evenyag reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Every time we upgrade datafusion needs 1k+ lines of code......

benchmarks/Cargo.toml Outdated Show resolved Hide resolved
src/script/src/python/pyo3/builtins.rs Show resolved Hide resolved
tests/cases/standalone/common/types/decimal/decimal_aggregates.result Show resolved Hide resolved
@waynexia
remove dead code
363a28e 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
evenyag approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the output of first_value/last_value is reasonable.

fengjiachun
fengjiachun reviewed May 31, 2024
View reviewed changes
src/promql/src/extension_plan/empty_metric.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/histogram_fold.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/instant_manipulate.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/normalize.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/range_manipulate.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/scalar_calculate.rs Outdated Show resolved Hide resolved
src/promql/src/extension_plan/union_distinct_on.rs Outdated Show resolved Hide resolved
@waynexia @fengjiachun
Apply suggestions from code review
7b3fd26 
Co-authored-by: Jeremyhi <jiachun_feng@proton.me>
@waynexia waynexia requested a review from fengjiachun May 31, 2024 10:18
@waynexia
format file
ce44f10 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia waynexia enabled auto-merge June 1, 2024 13:41
@waynexia waynexia added this pull request to the merge queue Jun 1, 2024
Merged via the queue into GreptimeTeam:main with commit c2218f8 Jun 1, 2024
21 of 28 checks passed
@waynexia waynexia deleted the bump-datafusion-37 branch June 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waynexia @fengjiachun @evenyag