Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): make write path faster with shared lock #4073

Merged
merged 3 commits into from
May 31, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

make flow's insert request faster to handle

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Previously everytime a insert request comes in a exclusive lock on flow node's ctx is acquired, which is unnecessary, hence now it will only acquire a shared read lock, and send rows into flow node

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 30, 2024
@discord9 discord9 marked this pull request as ready for review May 31, 2024 03:59
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 85.26%. Comparing base (fcfcf86) to head (48e50a3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4073      +/-   ##
==========================================
- Coverage   85.53%   85.26%   -0.27%     
==========================================
  Files         991      991              
  Lines      172933   172936       +3     
==========================================
- Hits       147925   147461     -464     
- Misses      25008    25475     +467     

@waynexia waynexia added this pull request to the merge queue May 31, 2024
Merged via the queue into GreptimeTeam:main with commit ea49f8a May 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants